Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exhook): fix obsolete SSL files aren't deleted after the Exhook config update #9432

Merged
merged 2 commits into from Nov 29, 2022

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Nov 28, 2022

This is a follow-up PR same as #9411, and fixed the Chinese changes

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change
    EMQX-8298
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

@lafirest lafirest marked this pull request as ready for review November 28, 2022 09:58
@coveralls
Copy link
Collaborator

coveralls commented Nov 28, 2022

Pull Request Test Coverage Report for Build 3563750352

  • 14 of 15 (93.33%) changed or added relevant lines in 1 file are covered.
  • 26 unchanged lines in 13 files lost coverage.
  • Overall coverage decreased (-0.004%) to 78.18%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_exhook/src/emqx_exhook_mgr.erl 14 15 93.33%
Files with Coverage Reduction New Missed Lines %
apps/emqx_management/src/emqx_mgmt_util.erl 1 13.79%
apps/emqx_bridge/src/emqx_bridge.erl 1 85.11%
apps/emqx/src/emqx_banned.erl 1 92.42%
apps/emqx/src/emqx_connection.erl 1 87.61%
apps/emqx/src/emqx_flapping.erl 1 85.11%
apps/emqx/src/emqx_broker.erl 1 82.42%
apps/emqx/src/emqx_router_helper.erl 1 86.27%
apps/emqx_modules/src/emqx_delayed.erl 1 94.78%
apps/emqx_authz/src/emqx_authz_schema.erl 1 90.28%
apps/emqx/src/emqx_cm.erl 2 90.83%
Totals Coverage Status
Change from base Build 3561074289: -0.004%
Covered Lines: 20985
Relevant Lines: 26842

💛 - Coveralls

@lafirest lafirest requested a review from a team November 28, 2022 10:09
@lafirest lafirest merged commit e6e5597 into emqx:master Nov 29, 2022
@lafirest lafirest deleted the fix/exhook_ssl_management branch November 29, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants