Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/fuzzing errors v50 #9477

Merged
merged 2 commits into from Dec 6, 2022
Merged

Conversation

lafirest
Copy link
Member

@lafirest lafirest commented Dec 5, 2022

Fixes

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change
    EMQX-8305
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

@lafirest lafirest force-pushed the fix/fuzzing_errors_v50 branch 2 times, most recently from de73d28 to b3394cb Compare December 5, 2022 11:51
@lafirest lafirest marked this pull request as ready for review December 5, 2022 11:52
@lafirest lafirest requested a review from a team December 5, 2022 11:53
@coveralls
Copy link
Collaborator

coveralls commented Dec 5, 2022

Pull Request Test Coverage Report for Build 3621395603

  • 33 of 40 (82.5%) changed or added relevant lines in 1 file are covered.
  • 28 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.06%) to 78.382%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx/src/emqx_frame.erl 33 40 82.5%
Files with Coverage Reduction New Missed Lines %
apps/emqx_management/src/emqx_mgmt_util.erl 1 13.79%
apps/emqx_bridge/src/emqx_bridge.erl 1 85.11%
apps/emqx/src/emqx_os_mon.erl 1 82.61%
apps/emqx_machine/src/emqx_machine.erl 1 79.31%
apps/emqx_dashboard/src/emqx_dashboard_monitor.erl 1 69.44%
apps/emqx/src/emqx_packet.erl 1 85.88%
apps/emqx/src/emqx_frame.erl 2 87.25%
apps/emqx_resource/src/emqx_resource_manager.erl 2 87.75%
apps/emqx/src/emqx_broker.erl 4 82.97%
apps/emqx/src/emqx_ws_connection.erl 4 79.56%
Totals Coverage Status
Change from base Build 3619938324: 0.06%
Covered Lines: 21044
Relevant Lines: 26848

💛 - Coveralls

zmstone
zmstone previously approved these changes Dec 5, 2022
@lafirest lafirest merged commit 3e29e37 into emqx:release-50 Dec 6, 2022
@lafirest lafirest deleted the fix/fuzzing_errors_v50 branch December 6, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants