Fix status code for lwm2m clients in api #9480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3656238166
💛 - Coveralls |
olcai
force-pushed
the
fix-status-code-for-lwm2m-clients-in-api
branch
from
665787c
to
a101ac8
Compare
olcai
commented
Dec 6, 2022
sstrigler
reviewed
Dec 6, 2022
sstrigler
reviewed
Dec 6, 2022
thalesmg
previously approved these changes
Dec 6, 2022
olcai
force-pushed
the
fix-status-code-for-lwm2m-clients-in-api
branch
2 times, most recently
from
c521910
to
dfe1cbf
Compare
thalesmg
previously approved these changes
Dec 8, 2022
sstrigler
previously approved these changes
Dec 8, 2022
olcai
force-pushed
the
fix-status-code-for-lwm2m-clients-in-api
branch
from
dfe1cbf
to
2b67a07
Compare
sstrigler
previously approved these changes
Dec 9, 2022
olcai
force-pushed
the
fix-status-code-for-lwm2m-clients-in-api
branch
2 times, most recently
from
55330e3
to
eb3e1ad
Compare
Change the return for lwm2m client API posts from 200 to 204 since they contain no content.
Add test coverage for HTTP 204 returns from lwm2m client API posts. This includes a small refactoring of the request functionality in emqx_mgmt_api_test_util.
olcai
force-pushed
the
fix-status-code-for-lwm2m-clients-in-api
branch
from
eb3e1ad
to
272337c
Compare
sstrigler
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a HTTP POST to
/gateway/lwm2m/clients/{clientid}/readreturned 200 without a response body. This PR changes this so thatread,writeandobserveall return 204 - No Content since they all share the same semantics.Fixes EMQX-7983.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/dirBackward Compatibility
More information