Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1219 fix shared sub sticky #9578

Merged
merged 6 commits into from Dec 20, 2022
Merged

1219 fix shared sub sticky #9578

merged 6 commits into from Dec 20, 2022

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Dec 19, 2022 •
edited

Fixes EMQX-7741

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • [n/a] For EMQX 4.x: appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change
  • [n/a] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • [n/a] In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

Backward Compatibility

More information

@zmstone zmstone requested a review from a team December 19, 2022 18:07
@zmstone
fix(shared): handle unsubscribe for sticky strategy
29f394a 
prior to this change, the message is dispatched to a shared subscriber
even after unsubscribed
@zmstone
docs: update change logs
9d1e41b
@zmstone
refactor(shared_sub): improve sticky strategy performance
4f1fb0b 
* avoid calling ets:select twice for sticky strategy
* when the calling process is terminating, no loop-back dispatch
@zmstone
fix(shared_sub): insert alive pid table at mnesia table event
ad3a793
@zmstone
refactor: delete stale code
e932569 
'hash' strategy has been removed from config schema
hence no need to keep the compatibility code
thalesmg
thalesmg approved these changes Dec 20, 2022
View reviewed changes
apps/emqx/src/emqx_schema.erl Show resolved Hide resolved
@zmstone zmstone merged commit b5dbfcf into emqx:master Dec 20, 2022
@zmstone zmstone deleted the 1219-fix-shared-sub-sticky branch December 20, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalesmg thalesmg thalesmg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zmstone @thalesmg