feat(emqx_bridge): add /bridges_probe API endpoint #9585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
reviewed
Dec 20, 2022
sstrigler
force-pushed
the
EMQX-8571-bring-back-connectors-test-as-bridge-test
branch
4 times, most recently
from
63cbd5e
to
bd72c14
Compare
sstrigler
force-pushed
the
EMQX-8571-bring-back-connectors-test-as-bridge-test
branch
from
bd72c14
to
0a77c48
Compare
sstrigler
changed the title
zmstone
approved these changes
Dec 21, 2022
|
as discussed: should follow up with PR to refactor
|
zmstone
reviewed
Dec 21, 2022
thalesmg
reviewed
Dec 21, 2022
| end. | ||
|
|
||
| parse_url(Url) -> | ||
| case string:split(Url, "//", leading) of |
There was a problem hiding this comment.
Nit: maybe uri_string:parse could be used?
There was a problem hiding this comment.
next time, going to be deleted anyway :)
|
Follow up ticket: https://emqx.atlassian.net/browse/EMQX-8588 |
sstrigler
deleted the
EMQX-8571-bring-back-connectors-test-as-bridge-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-8571
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/dir