refactor(metrics): change gauge metrics to be scoped by worker id #9605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
refactor-gauge-metrics-e50
branch
2 times, most recently
from
ef3d229
to
50b87fd
Compare
Currently, we face several issues trying to keep resource metrics reasonable. For example, when a resource is re-created and has its metrics reset, but then its durable queue resumes its previous work and leads to strange (often negative) metrics. Instead using `counters` that are shared by more than one worker to manage gauges, we introduce an ETS table whose key is not only scoped by the Resource ID as before, but also by the worker ID. This way, when a worker starts/terminates, they should set their own gauges to their values (often 0 or `replayq:count` when resuming off a queue). With this scoping and initialization procedure, we'll hopefully avoid hitting those strange metrics scenarios and have better control over the gauges.
thalesmg
force-pushed
the
refactor-gauge-metrics-e50
branch
from
50b87fd
to
dc1e46c
Compare
zmstone
reviewed
Dec 27, 2022
| } | ||
| label { | ||
| en: "Kafka Consumer" | ||
| zh: "卡夫卡消费者" |
There was a problem hiding this comment.
Suggested change
| zh: "卡夫卡消费者" | |
| zh: "Kafka 消费者" |
zmstone
reviewed
Dec 27, 2022
| } | ||
| label { | ||
| en: "Kafka Consumer" | ||
| zh: "卡夫卡消费者" |
There was a problem hiding this comment.
Suggested change
| zh: "卡夫卡消费者" | |
| zh: "Kafka 消费者" |
zmstone
reviewed
Dec 27, 2022
| consumer_kafka_opts { | ||
| desc { | ||
| en: "Kafka consumer configs." | ||
| zh: "Kafka消费者配置。" |
There was a problem hiding this comment.
Suggested change
| zh: "Kafka消费者配置。" | |
| zh: "Kafka 消费者配置。" |
zmstone
reviewed
Dec 27, 2022
| en: "MQTT to Kafka" | ||
| zh: "MQTT 到 Kafka" | ||
| en: "Kafka Producer" | ||
| zh: "卡夫卡制片人" |
There was a problem hiding this comment.
Suggested change
| zh: "卡夫卡制片人" | |
| zh: "Kafka 生产者" |
zmstone
reviewed
Dec 27, 2022
| } | ||
| label { | ||
| en: "Kafka topic" | ||
| zh: "卡夫卡主题 " |
There was a problem hiding this comment.
Suggested change
| zh: "卡夫卡主题 " | |
| zh: "Kafka 主题 " |
|
Port of the gauge part of this for master (since e501 is a bit on hold): #9619 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://emqx.atlassian.net/browse/EMQX-8548
Currently, we face several issues trying to keep resource metrics
reasonable. For example, when a resource is re-created and has its
metrics reset, but then its durable queue resumes its previous work
and leads to strange (often negative) metrics.
Instead using
countersthat are shared by more than one worker tomanage gauges, we introduce an ETS table whose key is not only scoped
by the Resource ID as before, but also by the worker ID. This way,
when a worker starts/terminates, they should set their own gauges to
their values (often 0 or
replayq:countwhen resuming off a queue).With this scoping and initialization procedure, we'll hopefully avoid
hitting those strange metrics scenarios and have better control over
the gauges.
Related Wolff PR: kafka4beam/wolff#41