refactor: use string type for server and servers #9614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
1222-fix-parse-server-port
branch
14 times, most recently
from
e2737b7
to
168dd71
Compare
thalesmg
reviewed
Dec 29, 2022
thalesmg
reviewed
Dec 29, 2022
|
|
||
| -export([resolve_dns/2]). | ||
|
|
||
| %% @doc Mostly for meck. |
There was a problem hiding this comment.
Q: using the unstick option doesn't work?
There was a problem hiding this comment.
It's not a sticky module.
The issue of mocking inet_res is it has too large of a scope which may cause the tests to become flaky.
thalesmg
reviewed
Dec 29, 2022
| end. | ||
|
|
||
| %% HOCON tries to be very informative about all the detailed errors | ||
| %% it's maybe too much when reporting to the user |
There was a problem hiding this comment.
Would be interesting to have a way to disable this compaction when more info is needed?
There was a problem hiding this comment.
yeah.
don't feel like it's a high prio at the moment.
thalesmg
reviewed
Dec 29, 2022
thalesmg
reviewed
Dec 29, 2022
zmstone
force-pushed
the
1222-fix-parse-server-port
branch
from
168dd71
to
7e00fa0
Compare
thalesmg
previously approved these changes
Dec 30, 2022
| @@ -18,151 +18,135 @@ | |||
|
|
|||
| -include_lib("eunit/include/eunit.hrl"). | |||
|
|
|||
| -define(DEFAULT_MONGO_PORT, 27017). | |||
| srv_record_test() -> | |||
| with_dns_mock( | |||
There was a problem hiding this comment.
There's also emqx_common_test_helpers:with_mock/4.
this is to make dialyzer happy
zmstone
force-pushed
the
1222-fix-parse-server-port
branch
from
c2b67c1
to
b30f2ea
Compare
thalesmg
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-8600
Refactor the
serverandserversfields schema to usestring()type for better code reuss.Also better readability: the
server()type was alist().This PR also included an enhancement to allow setting
host.name:portfrom environment variable.Prior to this change, the
env EMQX_BRIDGES__MQTT__AAA__SERVER='localhost:1883'is parsed as#{<<"server">> => #{<<"localhost" => 1883}}then end up in a type check failure.This has caused quite some confusion for users who don't know that the value has to be quoted.
After this fix, the
converterforserverandserverswill try to format the map back to comma-separatedhost.name:portlist.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/dir