Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): fix expiry_interval unit error #9637

Merged
merged 5 commits into from Jan 9, 2023

Conversation

HJianBo
Copy link
Member

@HJianBo HJianBo commented Dec 29, 2022

  1. The unit of expiry_interval was changed in 0704cbc in the previous implementation of 5.0, but the corresponding HTTP API returns were not changed accordingly. So we fixed it in this PR.
  2. The unnecessary search parameter proto_name has been removed because all clients' proto_names must be MQTT, so this parameter is meaningless.

@HJianBo HJianBo marked this pull request as ready for review December 30, 2022 01:26
zhongwencool
zhongwencool previously approved these changes Dec 30, 2022
changes/v5.0.14-en.md Outdated Show resolved Hide resolved
@id
Copy link
Collaborator

id commented Jan 3, 2023

@HJianBo please rebase on latest master and address changelog conflict

lafirest
lafirest previously approved these changes Jan 4, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3852146036

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 19 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.06%) to 79.817%

Files with Coverage Reduction New Missed Lines %
apps/emqx_authz/src/emqx_authz_schema.erl 1 90.28%
apps/emqx_machine/src/emqx_machine.erl 1 79.31%
apps/emqx/src/bpapi/emqx_bpapi.erl 1 95.83%
apps/emqx/src/emqx_connection.erl 1 88.47%
apps/emqx/src/emqx_logger.erl 1 80.49%
apps/emqx/src/emqx_router_helper.erl 1 86.27%
apps/emqx/src/emqx_cm.erl 2 90.37%
apps/emqx/src/emqx_reason_codes.erl 11 89.71%
Totals Coverage Status
Change from base Build 3848746808: 0.06%
Covered Lines: 22736
Relevant Lines: 28485

💛 - Coveralls

@HJianBo HJianBo merged commit 6f5057b into emqx:master Jan 9, 2023
@HJianBo HJianBo deleted the fix-clients-api branch January 9, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants