fix(mgmt_api): remove possibility to set clientid in /publish API #9667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olcai
commented
Jan 3, 2023
olcai
commented
Jan 3, 2023
thalesmg
previously approved these changes
Jan 3, 2023
qzhuyan
previously approved these changes
Jan 4, 2023
olcai
force-pushed
the
remove-clientid-in-publish-request-body
branch
from
57632e8
to
dfbbe36
Compare
thalesmg
previously approved these changes
Jan 4, 2023
qzhuyan
reviewed
Jan 4, 2023
olcai
force-pushed
the
remove-clientid-in-publish-request-body
branch
from
dfbbe36
to
7bcd351
Compare
thalesmg
previously approved these changes
Jan 4, 2023
lafirest
previously approved these changes
Jan 4, 2023
To avoid security confusion, we remove the possibility to specify the client ID in the request body for /publish and /publish/bulk.
olcai
force-pushed
the
remove-clientid-in-publish-request-body
branch
from
7bcd351
to
19033c8
Compare
qzhuyan
previously approved these changes
Jan 10, 2023
ieQu1
previously approved these changes
Jan 10, 2023
zmstone
reviewed
Jan 10, 2023
zmstone
reviewed
Jan 10, 2023
sstrigler
previously approved these changes
Jan 10, 2023
zmstone
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid security confusion, we remove the possibility to specify the client ID in the request body for
/publishand/publish/bulk.Fixes EMQX-8385.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/dir