Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emqx_metrics): Sliding window samples #9671

Merged
merged 1 commit into from Jan 10, 2023
Merged

Conversation

ieQu1
Copy link
Member

@ieQu1 ieQu1 commented Jan 3, 2023

Fixes EMQX-6741.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

@ieQu1 ieQu1 force-pushed the metrics branch 8 times, most recently from 265236b to e0c5695 Compare January 4, 2023 13:47
@ieQu1
Copy link
Member Author

ieQu1 commented Jan 4, 2023

The failed test is known to be flaky

@ieQu1 ieQu1 marked this pull request as ready for review January 4, 2023 15:18
@ieQu1 ieQu1 requested review from a team, lafirest and thalesmg as code owners January 4, 2023 15:18
thalesmg
thalesmg previously approved these changes Jan 4, 2023
apps/emqx/src/emqx_metrics_worker.erl Outdated Show resolved Hide resolved
apps/emqx/src/emqx_metrics_worker.erl Outdated Show resolved Hide resolved
apps/emqx/src/emqx_metrics_worker.erl Outdated Show resolved Hide resolved
thalesmg
thalesmg previously approved these changes Jan 4, 2023
@ieQu1 ieQu1 merged commit 13f1ab6 into emqx:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants