Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(paging): respect matchspec even if qs is empty when counting #9749

Merged
merged 2 commits into from Jan 13, 2023

Conversation

keynslug
Copy link
Contributor

@keynslug keynslug commented Jan 13, 2023

Before this fix, to provide count in the response metadata we might end up counting all the elements in the underlying table even if the query involves a match specification.


EMQX-8720

@keynslug keynslug requested review from a team, lafirest and sstrigler as code owners January 13, 2023 09:34
zmstone
zmstone previously approved these changes Jan 13, 2023
@zmstone zmstone merged commit bb3dceb into emqx:master Jan 13, 2023
@keynslug keynslug deleted the fix/count-respect-matchspec branch January 13, 2023 13:29
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3910877797

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 36 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.01%) to 79.982%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_management/src/emqx_mgmt_api.erl 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
apps/emqx_conf/src/emqx_conf_schema.erl 1 92.86%
apps/emqx_machine/src/emqx_machine.erl 1 79.31%
apps/emqx_management/src/emqx_mgmt_api_trace.erl 1 86.49%
apps/emqx/src/emqx_broker.erl 1 84.07%
apps/emqx/src/emqx_flapping.erl 1 85.11%
apps/emqx/src/emqx_logger.erl 1 80.49%
apps/emqx/src/emqx_os_mon.erl 1 84.06%
apps/emqx/src/emqx_router_helper.erl 1 86.27%
apps/emqx/src/emqx_schema.erl 1 90.91%
apps/emqx/src/emqx_session.erl 1 87.2%
Totals Coverage Status
Change from base Build 3910231074: -0.01%
Covered Lines: 23010
Relevant Lines: 28769

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants