fix(emqx_management): delete files after trace log download #9781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sstrigler
requested review from
a team,
lafirest and
sstrigler
as code owners
olcai
force-pushed
the
delete-zip-file-from-trace-log-download
branch
from
d390cf5
to
f3c98a2
Compare
Pull Request Test Coverage Report for Build 3938431170
💛 - Coveralls |
We only deleted the resulting zip after a trace file download, not the actual trace files. This adds a deletion of the uncompressed trace files as well. It also creates unique directories when collecting trace files so that concurrent downloads doesn't overwrite files in transit.
olcai
force-pushed
the
delete-zip-file-from-trace-log-download
branch
from
f3c98a2
to
784e9ad
Compare
olcai
commented
Jan 17, 2023
olcai
force-pushed
the
delete-zip-file-from-trace-log-download
branch
from
784e9ad
to
111268a
Compare
lafirest
reviewed
Jan 17, 2023
olcai
force-pushed
the
delete-zip-file-from-trace-log-download
branch
from
111268a
to
2cf2970
Compare
lafirest
previously approved these changes
Jan 17, 2023
thalesmg
previously approved these changes
Jan 17, 2023
thalesmg
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trace logs are downloaded, a zip file is created containing all requested trace logs. After the client has downloaded the zip file, the gathered files need to be deleted. This PR implements file deletion and also creates a unique directory so that concurrent downloads doesn't interfere with each other.
Fixes EMQX-8470.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/<version>/(feat|fix)-<PR-id>.en.mdand.zh.mdfilesIf there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow upSchema changes are backward compatible