fix(resources): fix resource lifecycle #9884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savonarola
force-pushed
the
resource-fixes
branch
from
bb6687b
to
9674d72
Compare
|
could you add more description to the PR about why this change? |
savonarola
force-pushed
the
resource-fixes
branch
from
9674d72
to
2906266
Compare
|
need a changelog because it affects the opensource edition too. |
* do not resume all buffer workers on successful healthcheck * do not pass undefined state to resource healthcheck callback
savonarola
force-pushed
the
resource-fixes
branch
from
2906266
to
14f528c
Compare
zmstone
previously approved these changes
Feb 2, 2023
zmstone
reviewed
Feb 2, 2023
zmstone
reviewed
Feb 2, 2023
zmstone
reviewed
Feb 2, 2023
zmstone
reviewed
Feb 2, 2023
zmstone
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMQX-8853
Do not resume all buffer workers on successful healthcheck. Previously after a successful healthcheck all buffer workers (for all resources) were resumed
Do not pass undefined state to resource healthcheck callback. If
on_startcallback never succeeded, the state of the resource isundefined. There is no sense to pass it toget_statuscallback.