Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retriers for rules v4.4 #9911

Merged
merged 5 commits into from Feb 6, 2023
Merged

Add retriers for rules v4.4 #9911

merged 5 commits into from Feb 6, 2023

Conversation

terry-xiaoyu
Copy link
Contributor

@terry-xiaoyu terry-xiaoyu commented Feb 4, 2023 •
edited

@terry-xiaoyu terry-xiaoyu requested review from thalesmg and a team as code owners February 4, 2023 04:55
@coveralls
Copy link

coveralls commented Feb 6, 2023 •
edited

Pull Request Test Coverage Report for Build 4099901129

  • 6 of 30 (20.0%) changed or added relevant lines in 2 files are covered.
  • 28 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.04%) to 74.924%
Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_rule_engine/src/emqx_rule_engine.erl 0 6 0.0%
apps/emqx_rule_engine/src/emqx_rule_monitor.erl 6 24 25.0%
Files with Coverage Reduction New Missed Lines %
apps/emqx_rule_engine/src/emqx_rule_engine.erl 1 71.19%
src/emqx_cm.erl 3 84.18%
src/emqx_sys_mon.erl 3 88.73%
apps/emqx_management/src/emqx_mgmt_data_backup.erl 8 66.03%
src/emqx_reason_codes.erl 13 88.57%
Totals Coverage Status
Change from base Build 4063553134: -0.04%
Covered Lines: 14724
Relevant Lines: 19652
💛 - Coveralls

@terry-xiaoyu terry-xiaoyu merged commit a1911f3 into emqx:main-v4.4 Feb 6, 2023
@terry-xiaoyu terry-xiaoyu deleted the add_retriers_for_rules-v4.4 branch February 6, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HJianBo HJianBo HJianBo approved these changes

@thalesmg thalesmg Awaiting requested review from thalesmg thalesmg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terry-xiaoyu @coveralls @HJianBo