Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): fix REPORT_CB/2 CRASH logs #9923

Merged
merged 1 commit into from Feb 7, 2023

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Feb 6, 2023

Fixes: #9920
Bug introduced in: #9861

See also EMQX-8882

The text formatter should not change maps to list.
This is usually not an issue, but for logs which has its own reporter_cb such as proc_lib:crash_report/4 and gen_server:error_info, the callback matches on map() type.

@zmstone zmstone requested review from a team, lafirest and thalesmg as code owners February 6, 2023 21:43
@zmstone zmstone force-pushed the 0206-fix-logger-formatter-crash branch 2 times, most recently from 797da9d to 26fa8f6 Compare February 6, 2023 22:46
@zmstone zmstone force-pushed the 0206-fix-logger-formatter-crash branch from 26fa8f6 to 4653ca6 Compare February 6, 2023 22:46
@zmstone zmstone merged commit 55889c9 into emqx:master Feb 7, 2023
@zmstone zmstone deleted the 0206-fix-logger-formatter-crash branch February 7, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disksup log crashes
2 participants