Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(emqx_prometheus): expose live_connections stats to prometheus #9929

Merged
merged 3 commits into from Feb 10, 2023

Conversation

olcai
Copy link
Contributor

@olcai olcai commented Feb 7, 2023

This exposes the stats live_connections.count and live_connections.max to Prometheus.

Sister to #9930 for v5.

Fixes EMQX-8852.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes (no: there is no test coverage of the prometheus code)
  • Changed lines covered in coverage report
  • Change log has been added to changes/ dir
  • appup files updated (execute scripts/update-appup.sh emqx)
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in Backward Compatibility section

@olcai olcai force-pushed the add-live-connections-to-prometheus branch from c32a708 to e6adefc Compare February 7, 2023 14:07
changes/v4.4.15-zh.md Outdated Show resolved Hide resolved
@olcai olcai force-pushed the add-live-connections-to-prometheus branch from e6adefc to ca340fa Compare February 7, 2023 14:18
@olcai olcai marked this pull request as ready for review February 7, 2023 14:19
@olcai olcai requested review from zhongwencool and a team as code owners February 7, 2023 14:19
@coveralls
Copy link
Collaborator

coveralls commented Feb 7, 2023

Pull Request Test Coverage Report for Build 4125685681

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 31 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.05%) to 74.939%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_prometheus/src/emqx_prometheus.erl 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
apps/emqx_auth_mnesia/src/emqx_acl_mnesia_migrator.erl 1 94.37%
src/emqx_alarm_handler.erl 1 30.77%
src/emqx_broker.erl 3 83.23%
src/emqx_router_helper.erl 3 80.85%
src/emqx_cm.erl 8 81.63%
src/emqx_reason_codes.erl 15 88.57%
Totals Coverage Status
Change from base Build 4123916300: -0.05%
Covered Lines: 14748
Relevant Lines: 19680

💛 - Coveralls

@zmstone
Copy link
Member

zmstone commented Feb 9, 2023

oops chanelog conflict .

ieQu1
ieQu1 previously approved these changes Feb 9, 2023
@olcai olcai merged commit dc97ac7 into emqx:main-v4.4 Feb 10, 2023
@olcai olcai deleted the add-live-connections-to-prometheus branch February 10, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants