New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(emqx_prometheus): expose live_connections stats to prometheus #9929
Merged
olcai
merged 3 commits into
emqx:main-v4.4
from
olcai:add-live-connections-to-prometheus
Feb 10, 2023
Merged
feat(emqx_prometheus): expose live_connections stats to prometheus #9929
olcai
merged 3 commits into
emqx:main-v4.4
from
olcai:add-live-connections-to-prometheus
Feb 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olcai
force-pushed
the
add-live-connections-to-prometheus
branch
from
February 7, 2023 14:07
c32a708
to
e6adefc
Compare
olcai
commented
Feb 7, 2023
olcai
force-pushed
the
add-live-connections-to-prometheus
branch
from
February 7, 2023 14:18
e6adefc
to
ca340fa
Compare
Pull Request Test Coverage Report for Build 4125685681
💛 - Coveralls |
6 tasks
olcai
force-pushed
the
add-live-connections-to-prometheus
branch
from
February 8, 2023 15:27
ca340fa
to
b1825c0
Compare
oops chanelog conflict . |
ieQu1
previously approved these changes
Feb 9, 2023
olcai
force-pushed
the
add-live-connections-to-prometheus
branch
from
February 9, 2023 16:21
b1825c0
to
3d41e58
Compare
ieQu1
approved these changes
Feb 9, 2023
zmstone
approved these changes
Feb 9, 2023
zhongwencool
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the stats
live_connections.count
andlive_connections.max
to Prometheus.Sister to #9930 for v5.
Fixes EMQX-8852.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/
dirappup
files updated (executescripts/update-appup.sh emqx
)