feat(quic): multi streams #9949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhuyan
force-pushed
the
dev/william/e5.0.1/multi-stream
branch
from
2de9371
to
b6fa61d
Compare
HJianBo
reviewed
Feb 10, 2023
| limiter_timer :: undefined | reference(), | ||
|
|
||
| %% QUIC conn owner pid if in use. | ||
| quic_conn_pid :: maybe(pid()) |
There was a problem hiding this comment.
Do we need concern about the Hot-upgrade compatibility once e5.0.0 released?
There was a problem hiding this comment.
I checked with @id , We don't support hot upgrade for e5.0.x
qzhuyan
force-pushed
the
dev/william/e5.0.1/multi-stream
branch
2 times, most recently
from
444c84e
to
690f774
Compare
ieQu1
reviewed
Feb 16, 2023
Could not find a way to ensure msquic flush the send buffer after calling ConnectionShutdown. So just close the ctrl stream and let conn owner shutdown the conn.
- setopts should go for stream - handle peer_needs_streams for none msquic clients
qzhuyan
force-pushed
the
dev/william/e5.0.1/multi-stream
branch
from
690f774
to
3982d43
Compare
qzhuyan
force-pushed
the
dev/william/e5.0.1/multi-stream
branch
from
3982d43
to
3486943
Compare
zmstone
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/<version>/(feat|fix)-<PR-id>.en.mdand.zh.mdfilesEMQX-8912