New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mqtt-bridge): disallow QoS 2 on ingress bridges #9952
Merged
keynslug
merged 3 commits into
emqx:master
from
keynslug:fix/mqtt-bridge-no-qos2-clean-start
Feb 10, 2023
Merged
fix(mqtt-bridge): disallow QoS 2 on ingress bridges #9952
keynslug
merged 3 commits into
emqx:master
from
keynslug:fix/mqtt-bridge-no-qos2-clean-start
Feb 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
reviewed
Feb 10, 2023
keynslug
force-pushed
the
fix/mqtt-bridge-no-qos2-clean-start
branch
from
February 10, 2023 14:18
0762079
to
243fa38
Compare
zmstone
reviewed
Feb 10, 2023
keynslug
force-pushed
the
fix/mqtt-bridge-no-qos2-clean-start
branch
from
February 10, 2023 15:00
243fa38
to
cee5723
Compare
zmstone
reviewed
Feb 10, 2023
zmstone
reviewed
Feb 10, 2023
keynslug
force-pushed
the
fix/mqtt-bridge-no-qos2-clean-start
branch
from
February 10, 2023 16:16
cee5723
to
dcee9e1
Compare
zmstone
approved these changes
Feb 10, 2023
Pull Request Test Coverage Report for Build 4145674796
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bring back the ability to configure
clean_start
, but only for subscriptions to the ingresses.EMQX-8934