Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mqtt-bridge): disallow QoS 2 on ingress bridges #9952

Merged
merged 3 commits into from Feb 10, 2023

Conversation

keynslug
Copy link
Contributor

@keynslug keynslug commented Feb 10, 2023

Also bring back the ability to configure clean_start, but only for subscriptions to the ingresses.


EMQX-8934

@keynslug keynslug requested review from a team and JimMoen as code owners February 10, 2023 13:21
@keynslug keynslug force-pushed the fix/mqtt-bridge-no-qos2-clean-start branch from 0762079 to 243fa38 Compare February 10, 2023 14:18
@keynslug keynslug force-pushed the fix/mqtt-bridge-no-qos2-clean-start branch from 243fa38 to cee5723 Compare February 10, 2023 15:00
@keynslug keynslug force-pushed the fix/mqtt-bridge-no-qos2-clean-start branch from cee5723 to dcee9e1 Compare February 10, 2023 16:16
@keynslug keynslug merged commit 2ed54e5 into emqx:master Feb 10, 2023
@keynslug keynslug deleted the fix/mqtt-bridge-no-qos2-clean-start branch February 10, 2023 16:40
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4145674796

  • 14 of 15 (93.33%) changed or added relevant lines in 1 file are covered.
  • 29 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.02%) to 80.729%

Changes Missing Coverage Covered Lines Changed/Added Lines %
apps/emqx_connector/src/mqtt/emqx_connector_mqtt_worker.erl 14 15 93.33%
Files with Coverage Reduction New Missed Lines %
apps/emqx_gateway/src/mqttsn/emqx_sn_channel.erl 1 73.04%
apps/emqx/src/emqx_broker.erl 1 84.83%
apps/emqx/src/emqx_cm.erl 1 89.91%
apps/emqx/src/emqx_config.erl 1 86.51%
apps/emqx/src/emqx_message.erl 1 94.83%
apps/emqx_resource/src/emqx_resource_buffer_worker.erl 3 93.04%
apps/emqx_resource/src/emqx_resource_metrics.erl 5 74.07%
apps/emqx/src/emqx_sys_mon.erl 5 86.46%
apps/emqx/src/emqx_reason_codes.erl 11 89.71%
Totals Coverage Status
Change from base Build 4145286896: 0.02%
Covered Lines: 23694
Relevant Lines: 29350

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants