New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0211 fix remsh #9961
Merged
Merged
0211 fix remsh #9961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of parsing the generated vm.args file, because the file might have been deleted
zmstone
force-pushed
the
0211-fix-remsh
branch
from
February 13, 2023 10:05
29f361f
to
d08eb01
Compare
id
reviewed
Feb 13, 2023
id
reviewed
Feb 13, 2023
Pull Request Test Coverage Report for Build 4164636620
💛 - Coveralls |
zmstone
force-pushed
the
0211-fix-remsh
branch
from
February 13, 2023 14:06
6a59f5f
to
936eab7
Compare
id
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EMQX-8936
The issue was exposed in a system where there is no compatible SSL dynamic library from the OS.
It failed to start a second
remote_console
session due to theps -ef
grep pattern included the firstremote_console
process in the output.This caused the script to consider that there are two EMQX nodes running, so it had to consult the bootstrap config file to resolve node name and node cookie.
Since
remote_console
is not a boot command, it did not load the zip package included SSL dynamic libs, hence failed to parse the configs.This PR included two changes, one fix and two enhancement
grep
pattern forps -ef
output linesps -ef
output, instead of reading the latest (generated)vm.<time>.args
file.-kernel ticktime
fromps -ef
output instead of RPC the live node to get itPR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/<version>/(feat|fix)-<PR-id>.en.md
and.zh.md
files