New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: add tls common conf hibernate after #9967
perf: add tls common conf hibernate after #9967
Conversation
a392be2
to
b3789aa
Compare
do you think we should intro a value currently having issues letting hocon and emqx_config cope with the value |
sc( | ||
duration(), | ||
#{ | ||
default => Df("hibernate_after", "5s"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here follows emqx 4.x that has default 5s
and personally I think it will be much easier to make it default to be disabled undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'd recommend using infinity
instead of undefined
for this.
Although their effect is the same.
But our other configurations are using infinity
such as
{"idle_timeout",
sc(
hoconsc:union([infinity, duration()])
...
https://www.erlang.org/doc/man/erlang.html#type-timeout
hibernate_after() = timeout()
timeout() = infinity | integer() >= 0
By the way, what happens if we set it to 0, is 0 the same as infinity?
Maybe we should also mention this in the document.
apps/emqx/i18n/emqx_schema_i18n.conf
Outdated
} | ||
label: { | ||
en: "hibernate after" | ||
zh: "闲置后休眠时间" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe 多久后休眠
will be better? Sorry, I can't think of a better word
b3789aa
to
4e6c7bf
Compare
Pull Request Test Coverage Report for Build 4175359685
💛 - Coveralls |
Fixes
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/<version>/(feat|fix)-<PR-id>.en.md
and.zh.md
files