fix(dashboard): fix swagger spec generation #9997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savonarola
force-pushed
the
fix-swagger-spec-gen
branch
from
8389440
to
b15b301
Compare
savonarola
requested review from
a team,
JimMoen and
lafirest
as code owners
lafirest
reviewed
Feb 23, 2023
lafirest
reviewed
Feb 23, 2023
|
I have a question, after this PR how could we tell users one API have been deprecated from a certain version? |
We may add this info to the |
savonarola
force-pushed
the
fix-swagger-spec-gen
branch
4 times, most recently
from
b063864
to
4373bd0
Compare
savonarola
commented
Feb 23, 2023
savonarola
force-pushed
the
fix-swagger-spec-gen
branch
from
4373bd0
to
f81d9e3
Compare
savonarola
force-pushed
the
fix-swagger-spec-gen
branch
from
4b39836
to
5bfd690
Compare
zmstone
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger says
deprecatedmetadata field should always be boolean https://swagger.io/specification/But in
hoconwe also support values like{since, "4.3.0"}, which result in"deprecated": "since(\"4.3.0\")"metadata.This incompatibility breaks some API client generators.