fix(mria_membership): call mria_rlog:role/1 safely
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeTupchiy
commented
Apr 25, 2023
| [#member{role = R} = M] -> M; | ||
| -define(lookup_member(N_, R_), | ||
| case ets:lookup(?TAB, N_) of | ||
| [#member{role = R_ = ROLE_} = M_] when ROLE_ /= undefined -> M_; |
There was a problem hiding this comment.
added ROLE_ /= undefined guard because R can be _..
ieQu1
previously approved these changes
Apr 25, 2023
This ensures mria_membership won't crash if RPC to another node fails.
SergeTupchiy
force-pushed
the
fix-mria-membership-safe-node-role
branch
from
915946b
to
49efd3a
Compare
ieQu1
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures mria_membership won't crash if RPC to another node fails.