feat: add custom diagnostic checks when mnesia is stuck #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ieQu1
reviewed
Sep 15, 2023
thalesmg
force-pushed
the
custom-diagnostics
branch
from
3506250
to
b5b6c08
Compare
zmstone
reviewed
Sep 18, 2023
| true -> | ||
| ok; | ||
| false -> | ||
| ?LOG(critical, "Configuration error: extra mnesia diagnostic " |
There was a problem hiding this comment.
Check when set, and raise an exception?
There was a problem hiding this comment.
#160 (comment)
we changed it to avoid raising any errors and possibly prevent recovery.
ieQu1
approved these changes
Sep 18, 2023
HJianBo
added a commit
to emqx/ekka
that referenced
this pull request
Sep 19, 2023
Included updates: - emqx/mria#160 - emqx/mria#161 - emqx/mria#162
HJianBo
added a commit
to HJianBo/emqx
that referenced
this pull request
Sep 19, 2023
Inclued ekka's updates: - emqx/ekka#214 - emqx/ekka#215 - emqx/ekka#216 - emqx/ekka#217 mria's updates: - emqx/mria#160 - emqx/mria#161 - emqx/mria#162
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://emqx.atlassian.net/browse/EMQX-10944