fix(resource_down): double check ownership #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After controlling_process/2 call, the old owner is demonitored *asynchronously*. That is we may get a stream/conn resource_down callback with the pid of old owner while the new ower is already set in the resource ctx. This change double check if the resource owner is the dead process pid and shutdown the resource only when they match.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
qzhuyan
commented
Jan 20, 2023
qzhuyan
force-pushed
the
dev/fix/res-down-callback-double-check-dead-pid
branch
from
580707f
to
290118e
Compare
zmstone
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After controlling_process/2 call, the old owner is demonitored asynchronously. That is we may get a stream/conn resource_down callback with the pid of old owner while the new ower is already set in the resource ctx.
This change double check if the resource owner is the dead process pid and shutdown the resource only when they match.