feat: future packet buffer #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes we find msquic deliver data to app out of order. This happens when system run out of memory for a short while and then recover OR the data is lost and never detect the loss or recover. We need this extra guard to ensure the order by using the absolute offset from the quic event. We prefer stuck the stream/connecion rather than providing wrong data to the APP layer.
new stream opt: disable_fpbuffer :: boolean(). default : false
zmstone
approved these changes
Jan 24, 2023
|
Just curious @qzhuyan, can you explain this statement?
For a single stream, MsQuic should never deliver data out of order. Across streams, all bets are off, because they are independent units. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we find msquic deliver data to app out of order.
This happens when system run out of memory for a short while and
then recover OR the data is lost and never detect the loss or recover.
We need this extra guard to ensure the order by using the absolute
offset from the quic event. We prefer stuck the stream/connection rather
than providing wrong data to the APP layer.