Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/william/prop test quicer nif #260

Merged
merged 15 commits into from
Feb 19, 2024

Conversation

qzhuyan
Copy link
Collaborator

@qzhuyan qzhuyan commented Feb 16, 2024

  • Add proper tests for NIF api smoke tests
    proper could not generate the maps for test, have to redefine with proplists types for proper tests.
  • Add proper stateful tests for testing the client.
  • cover report proper tests
  • Fix some minor bugs during proper tests
  • Update asan test to run with proper
  • breaking changes: rename all the parms by removing the level prefix since msquic GetParam/SetParam supports levels now.

c_src/quicer_config.c Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Feb 16, 2024

Pull Request Test Coverage Report for Build 7961960497

Details

  • -8 of 41 (80.49%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 83.8%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/quicer_server_conn_callback.erl 0 1 0.0%
c_src/quicer_nif.c 4 6 66.67%
c_src/quicer_config.c 20 25 80.0%
Files with Coverage Reduction New Missed Lines %
c_src/quicer_connection.c 1 83.24%
c_src/quicer_config.c 3 82.6%
Totals Coverage Status
Change from base Build 7960758791: 0.2%
Covered Lines: 3595
Relevant Lines: 4290

💛 - Coveralls

@qzhuyan qzhuyan force-pushed the dev/william/prop-test-quicer_nif branch from 9f53b72 to f9b38e7 Compare February 16, 2024 16:20
@qzhuyan qzhuyan force-pushed the dev/william/prop-test-quicer_nif branch 2 times, most recently from a6fb990 to 6e72402 Compare February 19, 2024 15:07
c_src/quicer_config.c Outdated Show resolved Hide resolved
include/quicer_types.hrl Outdated Show resolved Hide resolved
@qzhuyan qzhuyan force-pushed the dev/william/prop-test-quicer_nif branch from 6e72402 to 10b6b67 Compare February 19, 2024 15:33
@qzhuyan qzhuyan marked this pull request as ready for review February 19, 2024 15:52
@qzhuyan qzhuyan merged commit 09abe30 into emqx:main Feb 19, 2024
24 checks passed
@qzhuyan qzhuyan deleted the dev/william/prop-test-quicer_nif branch February 19, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants