adds specs

.rspec

@@ -0,0 +1,3 @@
+--color
+--require spec_helper
+--format documentation

Guardfile

@@ -0,0 +1,70 @@
+# A sample Guardfile
+# More info at https://github.com/guard/guard#readme
+
+## Uncomment and set this to only include directories you want to watch
+# directories %w(app lib config test spec features) \
+#  .select{|d| Dir.exists?(d) ? d : UI.warning("Directory #{d} does not exist")}
+
+## Note: if you are using the `directories` clause above and you are not
+## watching the project directory ('.'), then you will want to move
+## the Guardfile to a watched dir and symlink it back, e.g.
+#
+#  $ mkdir config
+#  $ mv Guardfile config/
+#  $ ln -s config/Guardfile .
+#
+# and, you'll have to watch "config/Guardfile" instead of "Guardfile"
+
+# Note: The cmd option is now required due to the increasing number of ways
+#       rspec may be run, below are examples of the most common uses.
+#  * bundler: 'bundle exec rspec'
+#  * bundler binstubs: 'bin/rspec'
+#  * spring: 'bin/rspec' (This will use spring if running and you have
+#                          installed the spring binstubs per the docs)
+#  * zeus: 'zeus rspec' (requires the server to be started separately)
+#  * 'just' rspec: 'rspec'
+
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  # Feel free to open issues for suggestions and improvements
+
+  # RSpec files
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  # Ruby files
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+
+  # Rails files
+  rails = dsl.rails(view_extensions: %w(erb haml slim))
+  dsl.watch_spec_files_for(rails.app_files)
+  dsl.watch_spec_files_for(rails.views)
+
+  watch(rails.controllers) do |m|
+    [
+      rspec.spec.call("routing/#{m[1]}_routing"),
+      rspec.spec.call("controllers/#{m[1]}_controller"),
+      rspec.spec.call("acceptance/#{m[1]}")
+    ]
+  end
+
+  # Rails config changes
+  watch(rails.spec_helper)     { rspec.spec_dir }
+  watch(rails.routes)          { "#{rspec.spec_dir}/routing" }
+  watch(rails.app_controller)  { "#{rspec.spec_dir}/controllers" }
+
+  # Capybara features specs
+  watch(rails.view_dirs)     { |m| rspec.spec.call("features/#{m[1]}") }
+  watch(rails.layouts)       { |m| rspec.spec.call("features/#{m[1]}") }
+
+  # Turnip features and steps
+  watch(%r{^spec/acceptance/(.+)\.feature$})
+  watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$}) do |m|
+    Dir[File.join("**/#{m[1]}.feature")][0] || "spec/acceptance"
+  end
+end

lib/paperclip-compression/base.rb

@@ -1,6 +1,8 @@
 module PaperclipCompression
   class Base
 
+    PROCESSOR_OPTIONS_KEY = :compression
+
     def initialize(file, first_processor, options = {})
       @file             = file
       @options          = options
@@ -76,7 +78,7 @@ def first_processor?
     end
 
     def init_default_opts(opts, type, default_opts)
-      if opts && (compression_opts = opts[:compression])
+      if opts && (compression_opts = opts[PROCESSOR_OPTIONS_KEY])
         if compression_opts.has_key?(type)
           if (type_opts = compression_opts[type])
             type_opts.kind_of?(String) ? type_opts : default_opts

lib/paperclip-compression/jpeg.rb

@@ -1,11 +1,12 @@
 module PaperclipCompression
   class Jpeg < Base
 
+    JPEG_KEY = :jpeg
     JPEGTRAN_DEFAULT_OPTS = '-copy none -optimize -perfect'
 
     def initialize(file, first_processor, options = {})
       super(file, first_processor, options)
-      @cli_opts = init_cli_opts(:jpeg, default_opts)
+      @cli_opts = init_cli_opts(JPEG_KEY, default_opts)
     end
 
     def make
@@ -25,9 +26,11 @@ def default_opts
     end
 
     def compress
-      Paperclip.run(command_path('jpegtran'),
-                    "#{@cli_opts} :src_path > :dst_path",
-                    src_path: @src_path, dst_path: @dst_path)
+      Paperclip.run(
+        command_path('jpegtran'),
+        "#{@cli_opts} :src_path > :dst_path",
+        src_path: @src_path, dst_path: @dst_path
+      )
     end
   end
 end

lib/paperclip-compression/png.rb

@@ -1,11 +1,12 @@
 module PaperclipCompression
   class Png < Base
 
-    OPTIPNG_DEFAULT_OPTS  = '-o 5 -quiet'
+    PNG_KEY = :png
+    OPTIPNG_DEFAULT_OPTS = '-o 5 -quiet'
 
     def initialize(file, first_processor, options = {})
       super(file, first_processor, options)
-      @cli_opts = init_cli_opts(:png, default_opts)
+      @cli_opts = init_cli_opts(PNG_KEY, default_opts)
     end
 
     def make
@@ -25,9 +26,11 @@ def default_opts
     end
 
     def compress
-      Paperclip.run(command_path('optipng'),
-                    "#{@cli_opts} -clobber :src_path -out :dst_path",
-                    src_path: @src_path, dst_path: @dst_path)
+      Paperclip.run(
+        command_path('optipng'),
+        "#{@cli_opts} -clobber :src_path -out :dst_path",
+        src_path: @src_path, dst_path: @dst_path
+      )
     end
   end
 end

paperclip-compression.gemspec

@@ -22,5 +22,6 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency 'bundler', '~> 1.3'
   s.add_development_dependency 'rake', '~> 10.1'
-  s.add_development_dependency 'rspec', '~> 2.14'
+  s.add_development_dependency 'rspec', '3.7.0'
+  s.add_development_dependency 'guard-rspec', '4.7.3'
 end

spec/paperclip-compression/jpeg_spec.rb

@@ -0,0 +1,146 @@
+RSpec.describe PaperclipCompression::Jpeg do
+
+  before(:each) do
+    path = File.join(PaperclipCompression.root, 'spec', 'support', 'test.jpg')
+    @file = File.new(path, 'rb')
+    @key = PaperclipCompression::Jpeg::JPEG_KEY
+  end
+
+  after(:each) do
+    @file.close
+  end
+
+  it 'processes the file via embedded binary' do
+    PaperclipCompression::Jpeg.new(@file, false).make
+  end
+
+  context 'when Paperclip default options are set' do
+
+    context 'and style based options are set' do
+      it 'uses style based options' do
+        with_paperclip_default_options(@key => '--abc') do
+          expect(Paperclip).to receive(:run).with(anything, run_options('--xyz'), anything)
+
+          jpeg = PaperclipCompression::Jpeg.new(@file, false, style_options(@key => '--xyz'))
+          jpeg.make
+        end
+      end
+    end
+
+    context 'and style based options are not set' do
+      it 'uses Paperclip default options' do
+        with_paperclip_default_options(@key => '--abc') do
+          expect(Paperclip).to receive(:run).with(anything,run_options('--abc'), anything)
+
+          jpeg = PaperclipCompression::Jpeg.new(@file, false)
+          jpeg.make
+        end
+      end
+    end
+
+    context 'and style based options are true' do
+      it 'uses style Paperclip default options' do
+        with_paperclip_default_options(@key => '--abc') do
+          expect(Paperclip).to receive(:run).with(anything,run_options('--abc'), anything)
+
+          jpeg = PaperclipCompression::Jpeg.new(@file, false, style_options(@key => true))
+          jpeg.make
+        end
+      end
+    end
+
+    context 'and style based options is false' do
+      it 'does not process the file' do
+        with_paperclip_default_options(@key => '--abc') do
+          expect(Paperclip).not_to receive(:run)
+
+          jpeg = PaperclipCompression::Jpeg.new(@file, false, style_options(@key => false))
+          jpeg.make
+        end
+      end
+    end
+
+    context 'and style based options is nil' do
+      it 'does not process the file' do
+        with_paperclip_default_options(@key => '--abc') do
+          expect(Paperclip).not_to receive(:run)
+
+          jpeg = PaperclipCompression::Jpeg.new(@file, false, style_options(@key => nil))
+          jpeg.make
+        end
+      end
+    end
+
+    context 'and style based options are blank string' do
+      it 'processes the file without additional options' do
+        with_paperclip_default_options(@key => '--abc') do
+          expect(Paperclip).to receive(:run).with(anything, run_options(''), anything)
+
+          jpeg = PaperclipCompression::Jpeg.new(@file, false, style_options(@key => ''))
+          jpeg.make
+        end
+      end
+    end
+  end
+
+  context 'when Paperclip default options are not set' do
+    context 'and style based options are set' do
+      it 'uses style based options' do
+        expect(Paperclip).to receive(:run).with(anything, run_options('--xyz'), anything)
+
+        jpeg = PaperclipCompression::Jpeg.new(@file, false, style_options(@key => '--xyz'))
+        jpeg.make
+      end
+    end
+
+    context 'and style based options are not set' do
+      it 'uses PaperclipCompression default options' do
+        expect(Paperclip).to receive(:run).with(anything, run_options(PaperclipCompression::Jpeg::JPEGTRAN_DEFAULT_OPTS), anything)
+
+        jpeg = PaperclipCompression::Jpeg.new(@file, false)
+        jpeg.make
+      end
+    end
+
+    context 'and style based options are true' do
+      it 'uses style PaperclipCompression default options' do
+        expect(Paperclip).to receive(:run).with(anything, run_options(PaperclipCompression::Jpeg::JPEGTRAN_DEFAULT_OPTS), anything)
+
+        jpeg = PaperclipCompression::Jpeg.new(@file, false, style_options(@key => true))
+        jpeg.make
+      end
+    end
+
+    context 'and style based options is false' do
+      it 'does not process the file' do
+        expect(Paperclip).not_to receive(:run)
+
+        jpeg = PaperclipCompression::Jpeg.new(@file, false, style_options(@key => false))
+        jpeg.make
+      end
+    end
+
+    context 'and style based options is nil' do
+      it 'does not process the file' do
+        expect(Paperclip).not_to receive(:run)
+
+        jpeg = PaperclipCompression::Jpeg.new(@file, false, style_options(@key => nil))
+        jpeg.make
+      end
+    end
+
+    context 'and style based options are blank string' do
+      it 'processes the file without additional options' do
+        expect(Paperclip).to receive(:run).with(anything, run_options(''), anything)
+
+        jpeg = PaperclipCompression::Jpeg.new(@file, false, style_options(@key => ''))
+        jpeg.make
+      end
+    end
+  end
+
+  def run_options(opts)
+    "#{opts} :src_path > :dst_path"
+  end
+
+end