This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Replace redbaron with python's ast module inside the module loader. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self, | ||
| root_fpath: str = get_root_fpath(), | ||
| py_fpath: str = get_root_py_fpath(), | ||
| parsing_strategy: Union[None, ParsingStrategy] = None, |
There was a problem hiding this comment.
You should be able to use Optional instead of Union[None,
There was a problem hiding this comment.
ooo, nice catch
There was a problem hiding this comment.
we should also prototype a pr-review agent which suggests fixes based on code review comments
… replace_redbaron_with_ast_
bhavitsharma
commented
Jul 6, 2023
| @@ -94,7 +94,7 @@ def _remove_docstrings(node: FSTNode) -> None: | |||
| if child_node is not node: | |||
| _remove_docstrings(child_node) | |||
|
|
|||
| module = py_module_loader.fetch_module(module_dotpath) | |||
| module = cast(RedBaron, py_module_loader.fetch_module(module_dotpath)) | |||
There was a problem hiding this comment.
sorry for the ugly cast, will be going away in next PR
Huntemall
pushed a commit
to Huntemall/automata-dev
that referenced
this pull request
Oct 30, 2023
…or-the-agent-config-complex major refactor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace RedBaron with python's AST module in the python loader.
Next steps: