review feedback [ci skip]

emscripten-core · Sep 24, 2020 · b3db6a9 · b3db6a9
1 parent 06ab316
commit b3db6a9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/system/lib/compiler-rt/emscripten_exception_builtins.c b/system/lib/compiler-rt/emscripten_exception_builtins.c
@@ -8,11 +8,6 @@
 /*
   References to these longjmp- and exceptions-supporting things are generated
   in the llvm backend.
-
-  Note that these might make more sense in compiler-rt, but they need to be
-  built with multithreading support when relevant (to avoid races between
-  threads that throw at the same time etc.), and compiler-rt is not built
-  that way atm.
 */
 
 #include <threads.h>

diff --git a/tests/core/pthread/exceptions.cpp b/tests/core/pthread/exceptions.cpp
@@ -44,13 +44,8 @@ pthread_t thread[NUM_THREADS];
 
 void CreateThread(int i)
 {
-  pthread_attr_t attr;
-  pthread_attr_init(&attr);
-  pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_JOINABLE);
-  static int counter = 1;
-  int rc = pthread_create(&thread[i], &attr, ThreadMain, (void*)i);
+  int rc = pthread_create(&thread[i], nullptr, ThreadMain, (void*)i);
   assert(rc == 0);
-  pthread_attr_destroy(&attr);
 }
 
 void loop() {