[wasm64] Fix makeHEAPView for addresses over 4gb

This enables all the cubegeom tests to pass
emscripten-core · Feb 13, 2024 · d790162 · d790162
1 parent fa57899
commit d790162
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -829,6 +829,8 @@ jobs:
             browser64_4gb.test_html5_webgl_create_context*
             browser64_4gb.test_sdl_image
             browser64_4gb.test_wasm_worker*
+            browser64_4gb.test_cube_explosion
+            browser64_4gb.test_cubegeom_*
             "
   test-browser-firefox:
     executor: bionic

diff --git a/src/parseTools.js b/src/parseTools.js
@@ -429,7 +429,16 @@ function makeSetValueImpl(ptr, pos, value, type) {
 function makeHEAPView(which, start, end) {
   const size = parseInt(which.replace('U', '').replace('F', '')) / 8;
   const shift = Math.log2(size);
-  const mod = size == 1 ? '' : (CAN_ADDRESS_2GB || MEMORY64) ? ('>>>' + shift) : ('>>' + shift);
+  let mod = '';
+  if (size) {
+    if (MEMORY64) {
+      mod = '/' + size;
+    } else if (CAN_ADDRESS_2GB) {
+      mod = '>>>' + shift;
+    } else {
+      mod = '>>' + shift;
+    }
+  }
   return `HEAP${which}.subarray((${start})${mod}, (${end})${mod})`;
 }