-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"npm install" step has suggestions #10291
"npm install" step has suggestions #10291
Comments
I wonder if that goes to stdout? I suppose npm should operate as usual, and print progress to stdout and errors to stderr? In that case we could just mute stdout in the subprocess spawn and let stderr items come through. Another way might be to pipe both streams in and grep for the output contents of stdout and stderr, and print them if process return code was nonzero, or some special keywords were found in the output? |
Another option might be to add |
Interesting.. i can't repro this. Does it happen when you run |
I don't see that message in the emscripten repo when I try now. Odd. (Anyhow, I think the issue of either hiding of giving context for npm output is pretty general here.) |
Fixes: emscripten-core/emscripten#10291 Also fix issue where an old/incorrect version of node could be used during SDK install since we were preferring activated versions of node.
Fixes: emscripten-core/emscripten#10291 Also fix issue where an old/incorrect version of node could be used during SDK install since we were preferring activated versions of node.
Installing the tot now, I saw
Could we hide all npm output? Or is that too dangerous?
cc @juj @sbc100
The text was updated successfully, but these errors were encountered: