Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm64: html5 callbacks throw type error when proxying to pthread #21851

Closed
jspanchu opened this issue Apr 29, 2024 · 0 comments · Fixed by #21852
Closed

wasm64: html5 callbacks throw type error when proxying to pthread #21851

jspanchu opened this issue Apr 29, 2024 · 0 comments · Fixed by #21852

Comments

@jspanchu
Copy link
Contributor

Looks like __emscripten_run_callback_on_thread is being invoked with 53-bit numbers instead of BigInt.

TypeError: Cannot convert 4215112 to a BigInt
    at __emscripten_run_callback_on_thread (vtkRenderingCoreCxxTests.js:7847:156)
    at Object.mouseEventHandlerFunc [as handlerFunc] (vtkRenderingCoreCxxTests.js:5691:4)
    at eventHandler.eventListenerFunc (vtkRenderingCoreCxxTests.js:4117:18)

Version of emscripten/emsdk:

emcc (Emscripten gcc/clang-like replacement + linker emulating GNU ld) 3.1.58 (a41843e0860e52c948c1fce20307933c6631c800)
clang version 10.0.0-4ubuntu1 
Target: wasm32-unknown-emscripten
Thread model: posix
InstalledDir: /usr/bin

Full link command and output with -v appended:
https://pastebin.com/y54Cky8S
sbc100 added a commit to sbc100/emscripten that referenced this issue Apr 29, 2024
@sbc100
[wasm64] Fix _emscripten_run_callback_on_thread under wasm64
d8fdce7 
The only test we have for this was in `test_interactive.py`.  I ran it
locally to ensure it now works.

Fixes: emscripten-core#21851
@sbc100 sbc100 mentioned this issue Apr 29, 2024
Merged
sbc100 added a commit to sbc100/emscripten that referenced this issue Apr 29, 2024
@sbc100
[wasm64] Fix _emscripten_run_callback_on_thread under wasm64
c786023 
The only test we have for this was in `test_interactive.py`.  I ran it
locally to ensure it now works.

Fixes: emscripten-core#21851
sbc100 added a commit that referenced this issue Apr 29, 2024
@sbc100
[wasm64] Fix _emscripten_run_callback_on_thread under wasm64 (#21852)
0649692 
The only test we have for this was in `test_interactive.py`.  I ran it
locally to ensure it now works.

Fixes: #21851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[wasm64] Fix _emscripten_run_callback_on_thread under wasm64 sbc100/emscripten
1 participant
@jspanchu