Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emsdk_env.sh racy #9090

Closed
vargaz opened this issue Jul 26, 2019 · 0 comments · Fixed by emscripten-core/emsdk#307
Closed

emsdk_env.sh racy #9090

vargaz opened this issue Jul 26, 2019 · 0 comments · Fixed by emscripten-core/emsdk#307

Comments

@vargaz
Copy link
Contributor

vargaz commented Jul 26, 2019

emsdk_env.sh calls emsdk construct_env which deletes the output file before creating the new one. If multiple copies of this script are ran in parallel in multiple shells, one copy could delete the file the other one is trying to source leading to errors like:
-bash: ./emsdk_set_env.sh: No such file or directory
vargaz added a commit to vargaz/emsdk that referenced this issue Jul 26, 2019
@vargaz
Avoid file creation/deletion races in emsdk_env.sh by using a tempora…
507b56d 
…ry file.

Fixes emscripten-core/emscripten#9090.
@vargaz vargaz mentioned this issue Jul 26, 2019
Merged
kripken pushed a commit to emscripten-core/emsdk that referenced this issue Jul 26, 2019
@vargaz @kripken
Avoid file creation/deletion races in emsdk_env.sh by using a tempora…
e2110d8 
…ry file(#307)

Fixes emscripten-core/emscripten#9090.
@vargaz vargaz mentioned this issue Jul 9, 2020
Merged
sbc100 added a commit to emscripten-core/emsdk that referenced this issue Jul 9, 2020
@sbc100
Avoid writing to file in emsdk_env.csh / emsdk_env.sh
92a366c 
This is an alternative fix for
emscripten-core/emscripten#9090 which recently
came up again after #539.

Tested with bash, tcsh and fish.
@sbc100 sbc100 mentioned this issue Jul 9, 2020
Merged
sbc100 added a commit to emscripten-core/emsdk that referenced this issue Jul 9, 2020
@sbc100
Avoid writing to file in emsdk_env.csh / emsdk_env.sh
98eaeb0 
This is an alternative fix for
emscripten-core/emscripten#9090 which recently
came up again after #539.

Tested with bash, tcsh and fish.
sbc100 added a commit to emscripten-core/emsdk that referenced this issue Jul 11, 2020
@sbc100
Avoid writing to file in emsdk_env.csh / emsdk_env.sh (#544)
d37abed 
This is an alternative fix for
emscripten-core/emscripten#9090 which recently
came up again after #539.

Tested with bash, tcsh and fish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid file creation/deletion races in emsdk_env.sh by using a tempora… vargaz/emsdk
1 participant
@vargaz