NODE_CODE_CACHING updates #11077
Merged
NODE_CODE_CACHING updates #11077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
May 4, 2020
| @@ -1069,6 +1069,7 @@ function createWasm() { | |||
| // to load ok, but we do actually recompile the binary every time). | |||
| var cachedCodeFile = '{{{ WASM_BINARY_FILE }}}.' + v8.cachedDataVersionTag() + '.cached'; | |||
| cachedCodeFile = locateFile(cachedCodeFile); | |||
| if (!nodeFS) nodeFS = require('fs'); | |||
There was a problem hiding this comment.
What would not normally get initialized? Maybe a comment?
There was a problem hiding this comment.
Well, this is just a normal code pattern we have in a bunch of places. Not sure it's worth commenting everywhere.
We don't want to require('fs') during startup all the time, so we do it on demand. Maybe we should have a helper function getNodeFS or such?
There was a problem hiding this comment.
(landing this, but if we have ideas to improve that pattern lets keep discussing and follow up with that)
There was a problem hiding this comment.
sgtm.. I just wasn't' familiar with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see v8.deserialize on WebAssembly module fails with "Unable to deserialize cloned data" nodejs/node#18265 (comment)