Remove all unused js optimizer passes #12414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Oct 5, 2020
|
Atm |
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jun 26, 2024
I believe the usage of these files was removed in emscripten-core#12414.
sbc100
added a commit
that referenced
this pull request
Jun 26, 2024
I believe the usage of these files was removed in #12414.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some TODOs from wasm2js where we thought about
running more of the old passes. I think that's not a good idea - they
will not run as our wasm2js output gets less and less like asm.js
anyhow. We'll need to write new acorn passes there, if we want to.
This removes safeHeap which we should be running (see #12410 (comment)),
but as it would be the only thing we use the js optimizer for from emcc.py,
and that isn't a recent regression, remove that too and I'll rewrite it for
acorn.