Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog entries for how to undo default changes #13909

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Add changelog entries for how to undo default changes #13909

merged 1 commit into from
Apr 15, 2021

Conversation

kripken
Copy link
Member

@kripken kripken commented Apr 15, 2021

See #13899.

@kripken kripken requested a review from sbc100 April 15, 2021 18:57
@kripken kripken enabled auto-merge (squash) April 15, 2021 18:58
@@ -42,13 +42,15 @@ Current Trunk
- Use LLVM's new pass manager by default, as LLVM does. This changes a bunch of
things about how LLVM optimizes and inlines, so it may cause noticeable
changes in compile times, code size, and speed, either for better or for
worse. (#13427)
worse. You can use the old pass manager (until LLVM removes it) by passing
`-flegacy-pass-manager` (#13427)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention the link flag too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could that be used? --lto-legacy-pass-manager needs to be passed to wasm-ld but the user doesn't run it directly. Do we have a way to pass flags to it? (I don't see one.)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes -Wl,--foo is the way to pass flags to the linker.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, sadly even if the user passed both compiler and linker flags they won't effect the standard libraries (which have a fixed set of flags they build with).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, does emcc parse and pass those to wasm-ld?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.. except for a few that we don't support and want to silently ignore (UNSUPPORTED_LLD_FLAGS)

@kripken kripken merged commit b047c06 into main Apr 15, 2021
@kripken kripken deleted the change branch April 15, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants