Mark pthread create/free functions as __noleakcheck
#15108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were trying to do this in `library_pthread.c` but this file (and the whole of libc) is not compiled specifically for lsan like it is for msan so in lsan builds that codepath was not being compiled it. Instead use JS-side mitigation which is to use `__noleakcheck`.
kripken
approved these changes
Sep 23, 2021
kleisauke
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were trying to do this in
library_pthread.cbut thisfile (and the whole of libc) is not compiled specifically for
lsan like it is for msan so in lsan builds that codepath was
not being compiled it.
Instead use JS-side mitigation which is to use
__noleakcheck.