Add support for specifying response file encoding #15426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Nov 4, 2021
|
Can you title this that same as before ("Add support for specifying response file encoding") and mention in the commit message that it is a second attempt at landing #15406? |
|
Can you add this new test to |
juj
changed the title
… the response file name, and autodetect the response file encoding using the suffix of the response file name if one is specified there.
juj
force-pushed
the
fix_response_files_encoding
branch
from
d1bbf4a
to
34db286
Compare
| @@ -36,6 +36,10 @@ See docs/process.md for more on how version tagging works. | |||
| 2.0.33 - 11/01/2021 | |||
| ------------------- | |||
| - Bug fixes | |||
| - Added support for specifying the text encoding to be used in response filenames | |||
There was a problem hiding this comment.
Changelog in wrong place?
curiousdannii
added a commit
to curiousdannii/emscripten
that referenced
this pull request
Nov 19, 2021
Changelog entry for emscripten-core#15426 was mistakenly added to 2.0.33
curiousdannii
added a commit
to curiousdannii/emscripten
that referenced
this pull request
Nov 19, 2021
Changelog entry for emscripten-core#15426 was mistakenly added to 2.0.33
sbc100
pushed a commit
that referenced
this pull request
Nov 19, 2021
Changelog entry for #15426 was mistakenly added to 2.0.33
ab-unity
pushed a commit
to Unity-Technologies/emscripten
that referenced
this pull request
Nov 30, 2021
) * Add support for specifying response file encoding using the suffix of the response file name, and autodetect the response file encoding using the suffix of the response file name if one is specified there. * Update Changelog * Adjust test to verify locale.getpreferredencoding() * Update ChangeLog * Improve comments * Update comment * Relocate comment * Update Changelog * Add test to windows config (cherry picked from commit 5db73a6) # Conflicts: # .circleci/config.yml
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
) * Add support for specifying response file encoding using the suffix of the response file name, and autodetect the response file encoding using the suffix of the response file name if one is specified there. * Update Changelog * Adjust test to verify locale.getpreferredencoding() * Update ChangeLog * Improve comments * Update comment * Relocate comment * Update Changelog * Add test to windows config
mmarczell-graphisoft
pushed a commit
to GRAPHISOFT/emscripten
that referenced
this pull request
Jan 5, 2022
…core#15577) Changelog entry for emscripten-core#15426 was mistakenly added to 2.0.33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
second attempt at landing #15406