Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process queued calls from other threads during sched_yeild #15897

Merged
merged 1 commit into from Jan 6, 2022

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Jan 6, 2022

This is part of two fixes for #15896. Ideally will followup
by also removing the proxying of atexit calls, but this alone
should fix this issue as written.

@sbc100 sbc100 requested a review from kripken January 6, 2022 14:42
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And a test almost all written too...

@kripken
Copy link
Member

kripken commented Jan 6, 2022

Oh, nevermind my comment about the test, I missed that this is on a branch that adds the test. Nice plan to use separate PRs.

@sbc100 sbc100 force-pushed the process_queue_during_yeild branch 2 times, most recently from 83af243 to a648364 Compare January 6, 2022 17:54
Base automatically changed from add_pthread_busy_wait_test to main January 6, 2022 18:33
This is part of two fixes for #15896.  Ideally will followup
by also removing the proxying of atexit calls, but this alone
should fix this issue as written.
@sbc100 sbc100 enabled auto-merge (squash) January 6, 2022 18:44
@sbc100 sbc100 merged commit 351f5f7 into main Jan 6, 2022
@sbc100 sbc100 deleted the process_queue_during_yeild branch January 6, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants