-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup ws usage for newer versions #16720
Conversation
a5993eb
to
6ab9796
Compare
Looks like the tests/sockets/ws can be removed as well. I think the Buffer wrapping can be removed by setting websocket.binaryType='arraybuffer' but I haven't tested. I'm happy to make those changes if desired. |
Ah yes it looks like |
If not, I can do it. |
sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. I'll let @juj give final approval since he wrote this code and knows it better than me.
I see this missed 3.1.8? I know it isn't considered urgent but it would be great if it could make it in soon. |
Upgrade to ws 8.5.0. Fixes #5971 #10264 #12813