Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent idle Workers from keeping Node.js app alive #18227

Merged
merged 12 commits into from Nov 18, 2022
Merged

Prevent idle Workers from keeping Node.js app alive #18227

merged 12 commits into from Nov 18, 2022

Commits on Nov 18, 2022

  1. Add .ref/.unref dance for Node.js workers

    @RReverser
    RReverser committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    14e9ec1 View commit details
    Browse the repository at this point in the history

  2. Better placement for worker.unref() 

    This fixes couple more tests.
    @RReverser
    RReverser committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    2010a48 View commit details
    Browse the repository at this point in the history

  3. Don't .unref if already need to run

    @RReverser
    RReverser committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    1ae57db View commit details
    Browse the repository at this point in the history

  4. Try to revert some tests

    @RReverser
    RReverser committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    5d61105 View commit details
    Browse the repository at this point in the history

  5. One more option

    @RReverser
    RReverser committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    a4047bb View commit details
    Browse the repository at this point in the history

  6. .unref under Node only

    @RReverser
    RReverser committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    1255f71 View commit details
    Browse the repository at this point in the history

  7. Try to revert one more test

    @RReverser
    RReverser committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    6327c6b View commit details
    Browse the repository at this point in the history

  8. Revert

    @RReverser
    RReverser committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    3e532d7 View commit details
    Browse the repository at this point in the history

  9. One more attempt

    @RReverser
    RReverser committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    6c7ac06 View commit details
    Browse the repository at this point in the history

  10. Add closure externs

    @RReverser
    RReverser committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    89cf13d View commit details
    Browse the repository at this point in the history

  11. Add comments to .ref/.unref

    @RReverser
    RReverser committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    763c60b View commit details
    Browse the repository at this point in the history

  12. Revert print -> logger.debug change

    @RReverser
    RReverser committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    07fd976 View commit details
    Browse the repository at this point in the history