Set pthread stack size when -sSTACK_SIZE is set
#18479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
pthread_stack_size
branch
2 times, most recently
from
15c8845
to
7042b11
Compare
sbc100
force-pushed
the
pthread_stack_size
branch
from
7042b11
to
e04cbae
Compare
dschuff
approved these changes
Jan 9, 2023
This was referenced Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was always my intention with #18191 but somehow it got left out. I think it makes sense that user to override
STACK_SIZEalso, by default, override the pthread stack size. Such users can always explicitly set the pthread stack size if they don't want this behaviour.See #18472