Add MIN_NODE_VERSION setting #18521
Merged
Add MIN_NODE_VERSION setting #18521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
min_node_version
branch
3 times, most recently
from
0302004
to
f793dc7
Compare
This, along with #18465 (which run tests on the oldest supported version of node) should pave the way for us to update the emsdk version node to something a little more modern. See emscripten-core/emsdk#829 This first thing I do with this setting is use it do disable `NODEJS_CATCH_REJECTION` by default when we are targeting node 15 and above.
sbc100
force-pushed
the
min_node_version
branch
from
f793dc7
to
d0408ba
Compare
sbc100
added a commit
that referenced
this pull request
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, along with #18465 (which run tests on the oldest supported version of node) should pave the way for us to update the emsdk version node to something a little more modern.
See emscripten-core/emsdk#829
This first thing I do with this setting is use it do disable
NODEJS_CATCH_REJECTIONby default when we are targeting node 15 and above.