Remove use of logging from ports builds #18624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_logging
branch
2 times, most recently
from
b4752ef
to
a5f9f56
Compare
kripken
approved these changes
Jan 30, 2023
sbc100
force-pushed
the
remove_logging
branch
2 times, most recently
from
2a40c02
to
265ee6b
Compare
This was just adding unnessary boilerplate to each individual port. We already print several lines of information when building a given port, and its all don't in generic code. e.g.: ``` ports:INFO: retrieving port: bullet from https://github.com/emscripten-ports/bullet/archive/version_1.zip ports:INFO: unpacking port: bullet cache:INFO: generating system library: sysroot/lib/wasm32-emscripten/libbullet.a... (this will be cached in "/usr/local/google/home/sbc/dev/wasm/emscripten/cache/sysroot/lib/wasm32-emscripten/libbullet.a" for subsequent builds) ``` For requests to make these things quieter in general see #18607 and 18622.
RReverser
pushed a commit
that referenced
this pull request
Mar 29, 2023
This was just adding unnessary boilerplate to each individual port. We already print several lines of information when building a given port, and its all don't in generic code. e.g.: ``` ports:INFO: retrieving port: bullet from https://github.com/emscripten-ports/bullet/archive/version_1.zip ports:INFO: unpacking port: bullet cache:INFO: generating system library: sysroot/lib/wasm32-emscripten/libbullet.a... (this will be cached in "/usr/local/google/home/sbc/dev/wasm/emscripten/cache/sysroot/lib/wasm32-emscripten/libbullet.a" for subsequent builds) ``` For requests to make these things quieter in general see #18607 and 18622.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was just adding unnessary boilerplate to each individual port. We already print several lines of information when building a given port, and its all don't in generic code. e.g.:
For requests to make these things quieter in general see #18607 and #18622.