Fix libpng and libfreetype port with wasm exceptions are enabled #19004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
freetype_wasm_longjmp
branch
2 times, most recently
from
e14801b
to
191b0d0
Compare
sbc100
added a commit
that referenced
this pull request
Mar 20, 2023
This seems to be the latest release that exists on the SDL2 branch of the upstream repository. I verified that both of own downstream patches that we had in the emscripten-ports fork have since landed upstream: libsdl-org/SDL_image@1d92df494 libsdl-org/SDL_image@840782235 I also verified that both of these made it into the 2.6.0 release. This change is needed as part of #19004 but it also allows us to delete our fork which is nice.
aheejin
reviewed
Mar 20, 2023
aheejin
reviewed
Mar 20, 2023
sbc100
added a commit
that referenced
this pull request
Mar 20, 2023
This seems to be the latest release that exists on the SDL2 branch of the upstream repository. I verified that both of own downstream patches that we had in the emscripten-ports fork have since landed upstream: libsdl-org/SDL_image@1d92df494 libsdl-org/SDL_image@840782235 I also verified that both of these made it into the 2.6.0 release. This change is needed as part of #19004 but it also allows us to delete our fork which is nice.
sbc100
added a commit
that referenced
this pull request
Mar 20, 2023
This seems to be the latest release that exists on the SDL2 branch of the upstream repository. I verified that both of own downstream patches that we had in the emscripten-ports fork have since landed upstream: libsdl-org/SDL_image@1d92df494 libsdl-org/SDL_image@840782235 I also verified that both of these made it into the 2.6.0 release. This change is needed as part of #19004 but it also allows us to delete our fork which is nice.
sbc100
force-pushed
the
freetype_wasm_longjmp
branch
3 times, most recently
from
4fc7c02
to
b0c8baa
Compare
sbc100
force-pushed
the
freetype_wasm_longjmp
branch
from
b0c8baa
to
6ce4384
Compare
Sadly, even though libpng can be compiled with setjmp/longjmp support some libraries such as openjpeg assume that setjmp support is included. Fixes: #19001
sbc100
force-pushed
the
freetype_wasm_longjmp
branch
from
6ce4384
to
8e5f75d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly, even though libpng can be compiled with setjmp/longjmp support
some libraries such as openjpeg assume that setjmp support is included.
Fixes: #19001