Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default log level to WARN to avoid spamming stderr #19085

Closed
wants to merge 1 commit into from
Closed

Change default log level to WARN to avoid spamming stderr #19085

wants to merge 1 commit into from

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Mar 28, 2023

By default we don't want random messages such as cache:INFO: generating system asset: from appearing on stdout.

EMCC_DEBUG and EMCC_VERBOSE can be used enable more info.

Fixes: #18622, #18607

@sbc100 sbc100 requested review from kripken, dschuff and juj March 28, 2023 00:13
@sbc100
Change default log level to WARN to avoid spamming stderr
eb403ef 
By default we don't want random messages such as `cache:INFO: generating
system asset:` from appearing on stdout.

EMCC_DEBUG and EMCC_VERBOSE can be used enable more info.

Fixes: #18622, #18607
dschuff
dschuff approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@dschuff dschuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also like this change.

@sbc100
Copy link
Collaborator Author

sbc100 commented Mar 29, 2023

Its not quite working how I want it to... will re-visit when I get some cycles.

@juj
Copy link
Collaborator

juj commented Mar 30, 2023

I do enjoy that I see when Emscripten is rebuilding e.g. libc and others in the INFO. That is because those builds take a relatively long time.

Though the recent addition where these command line directives get cached is distracting.

@sbc100 sbc100 mentioned this pull request May 1, 2023
Closed
sbc100 added a commit that referenced this pull request Jun 5, 2023
@sbc100
Add EMCC_LOGGING=0 to disable all logging
d89fb91 
This can be useful when running tests that want to check the stderr
of emscripten.

This was suggested as an aternative to #19085 and should fix #18607 but
maybe isn't quite right to solve #18622.

Fixes: #19085
@sbc100 sbc100 mentioned this pull request Jun 5, 2023
Merged
sbc100 added a commit that referenced this pull request Jun 5, 2023
@sbc100
Add EMCC_LOGGING=0 to disable all logging
c6eed5f 
This can be useful when running tests that want to check the stderr
of emscripten.

This was suggested as an aternative to #19085 and should fix #18607 but
maybe isn't quite right to solve #18622.

Fixes: #19085
@sbc100 sbc100 closed this in #19531 Jun 6, 2023
sbc100 added a commit that referenced this pull request Jun 6, 2023
@sbc100
Add EMCC_LOGGING=0 to disable all logging (#19531)
58ff5aa 
This can be useful when running tests that want to check the stderr
of emscripten.

This was suggested as an aternative to #19085 and should fix #18607 but
maybe isn't quite right to solve #18622.

Fixes: #19085
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschuff dschuff dschuff approved these changes

@kripken kripken Awaiting requested review from kripken

@juj juj Awaiting requested review from juj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Constant "generating system asset: symbol_lists/<hash>" in build
3 participants
@sbc100 @juj @dschuff