Enable WASM_BIGINT by default #19156

kripken · 2023-04-10T23:57:04Z

This explores the option of enabling it by default. To do that, fix our feature matrix on Safari (it was too pessimistic) and bump Firefox a few versions (but just to an ESR from 2019, which is still a very long time ago), and integrate the feature matrix in emcc.py.

kripken · 2023-04-11T00:13:28Z

Looks like we'd also need to bump the minimum node from 10.18 to 15.0, which is a big jump...

And the node-compat tests fail in this PR, but we could run then in a mode that adjust the min node version perhaps?

sbc100 · 2023-04-11T02:22:52Z

Looks like we'd also need to bump the minimum node from 10.18 to 15.0, which is a big jump...

Before we do that we would probably want to update the emsdk version of node which is currently on 14.18.2. Going from 14.18.2 to 15.X seems reasonable but we have had push back in the past when trying to update the emsdk version.

And the node-compat tests fail in this PR, but we could run then in a mode that adjust the min node version perhaps?

Yes, that seems reasonable.

sbc100 · 2023-04-11T02:24:00Z

emsdk node update PR that has been up for a long time now: emscripten-core/emsdk#829

kripken · 2023-04-11T17:03:26Z

Ah right, thanks @sbc100 . Ok, this should wait on that node upgrade then to happen first.

sbc100 · 2023-04-11T18:47:53Z

The emsdk update is now done

sbc100 · 2023-04-11T18:50:25Z

src/settings.js

@@ -1382,7 +1382,7 @@ var DYNCALLS = false;
 // i64 is used. If WASM_BIGINT is present, the default minimum supported browser
 // versions will be increased to the min version that supports BigInt.


This last sentence should probably just be removed I think

sbc100 · 2023-04-11T18:51:40Z

src/settings.js

 // MAX_INT (0x7FFFFFFF, or -1) specifies that target is not supported.
 // [link]
-var MIN_FIREFOX_VERSION = 65;
+var MIN_FIREFOX_VERSION = 68;


We should add this to the ChangeLog, along with a note about bigint itself being enabled by default.

emcc.py

test/test_core.py

test/test_other.py

sbc100 · 2023-04-12T23:14:26Z

test/test_core.py

    self.emcc_args += ['-lembind']
-    self.node_args += shared.node_bigint_flags()


Are there any remaining callers of node_bigint_flags?

This one is not needed, but there are still two uses after it, in emcc.py and gen_struct_info.py which I am not sure about.

To remove it in them, we might need to add node version checks...

sbc100 · 2023-04-12T23:14:43Z

I've very excited to see this change happening!

kripken · 2023-04-12T23:45:31Z

Thanks, feedback addressed. But note that there is a long road here given all the test failures, and I'll be splitting this up into smaller PRs once it works, so not sure it's worth reviewing eagerly.

This is still a version from 3 years ago, so it is a very small change, but it does bring us to a version that has wasm-bigint enabled, which will help #19156

) This version of node supports wasm-bigint by default, so it will help #19156 Node 16 is over 2 years old, and the node website already provides newer versions both for latest and for LTS. This is possible after emscripten-core/emsdk#829 made the emsdk install a 15.x version by default, and then emscripten-core/emsdk#1232 switched to 16.x.

sbc100 · 2023-06-21T18:15:06Z

There is a complication here, it turns out. While Safari 14.1 supports wasm BigInt integration, only Safari 15 supports BigInt64Array. We depend on BigInt64Array when WASM_BIGINT is enabled, and so right now in this PR we bump the minimal Safari to 14.1 and end up including a polyfill of 3.2K for BigInt64Array. That's a large regression in all our code size tests and probably we shouldn't do it.

The safest thing is to wait on this until we are ready to switch to Safari 15 by default, I think. That is, I'm not sure it's worth a partial upgrade for WASM_BIGINT+polyfill, we should wait until the polyfill is unneeded.

Could we at least make the default for WASM_BIGINT driven by the feature matrix, so that those folks who set the right min browser versions will get it by default? Or, for example, if you target only node and not the web?

dschuff · 2023-06-21T20:10:33Z

is all of that 3.2k polyfill necessary for our use of bigint64array? or can we get away with only part of it?

kripken · 2023-06-21T23:11:38Z

@dschuff We might not need all of it (e.g. I don't think we use copyWithin?), but we do use most of it AFAICT. That's enough of a regression to worry me.

kripken · 2023-06-21T23:14:21Z

@sbc100 We could split that part out of this PR, to enable bigint automatically if the user happens to target new-enough things. I'm not sure if it's worth the complexity, though - the big benefit is when we can change the default entirely, I think. Unless you think it's common for people to target new things?

kripken · 2023-06-22T18:30:42Z

Some tests fail here because this PR no longer does what it is advertised as doing: the default of WASM_BIGINT is set to the default based on the features, but as mentioned a few comments back, we need Safari 15 for full WASM_BIGINT support and we just depend on 14 for now. So this does not actually end up setting WASM_BIGINT by default in CI, causing certain test failures.

I'm not sure it's worth going through those atm - might be more churn than is worth it (add/remove annotations on tests, that will be redundant once we can actually depend on Safari 15). I lean towards leaving it for when we can actually flip the setting's default.

kripken added 4 commits April 10, 2023 16:40

yolo

ee34a80

make it work

5b5e426

fix

520301b

fix closure

85793ac

sbc100 reviewed Apr 11, 2023

View reviewed changes

kripken added 6 commits April 11, 2023 14:09

Merge remote-tracking branch 'origin/main' into safari.bigint

22393a4

fix wasm2js

9fe22ab

fix test

e255dad

fix

e1108d6

fix

314cf8a

cleanup

a52372d

sbc100 reviewed Apr 11, 2023

View reviewed changes

emcc.py Outdated Show resolved Hide resolved

test/test_core.py Outdated Show resolved Hide resolved

kripken added 7 commits April 11, 2023 15:41

more

c64adf2

fix

e7259ed

fixflake8

09ea912

work

6699531

fix

d907b0e

fix

af838e7

fix

9aac743

sbc100 reviewed Apr 12, 2023

View reviewed changes

kripken added 2 commits April 12, 2023 16:16

work

5142300

feedback

71ca03a

Merge remote-tracking branch 'origin/main' into safari.bigint

6973fea

This was referenced Apr 17, 2023

Update the minimum Firefox verson to 68 #19191

Merged

Update default minimum Node.js version to 16.0.0 #19192

Merged

kripken added 3 commits April 17, 2023 09:54

fix

560120a

fix

84836b2

Explain safari-bigint issue and set version to 15

356a840

kripken added a commit that referenced this pull request Apr 18, 2023

Update the minimum Firefox verson to 68 (#19191)

604fde4

This is still a version from 3 years ago, so it is a very small change, but it does bring us to a version that has wasm-bigint enabled, which will help #19156

kripken added 4 commits June 21, 2023 10:59

Merge remote-tracking branch 'origin/main' into safari.bigint

00aab91

Merge remote-tracking branch 'origin/main' into safari.bigint

0ca6930

fix

5985cdd

fix

8566684

kripken added 4 commits June 22, 2023 10:12

Merge remote-tracking branch 'origin/main' into safari.bigint

c35d241

fix

b537cc7

fix

339b323

fix

400f01e

kripken added 5 commits June 22, 2023 12:47

clean

62366ca

waka

2f8f82c

fix

8eab1f5

comment

c93f72f

fix

568ee40

kripken mentioned this pull request Jun 22, 2023

Fix dyncall() functions on i64 parameters in WASM_BIGINT mode #19689

Merged

kripken added 3 commits June 22, 2023 15:36

flip

fe12dc0

remove =1s

a42cb9e

merge [ci skip]

4998ef6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable WASM_BIGINT by default #19156

Enable WASM_BIGINT by default #19156

kripken commented Apr 10, 2023

kripken commented Apr 11, 2023

sbc100 commented Apr 11, 2023

sbc100 commented Apr 11, 2023

kripken commented Apr 11, 2023 •

edited

Loading

sbc100 commented Apr 11, 2023

sbc100 Apr 11, 2023

sbc100 Apr 11, 2023

sbc100 Apr 12, 2023

kripken Apr 12, 2023

kripken Apr 12, 2023

sbc100 commented Apr 12, 2023

kripken commented Apr 12, 2023

sbc100 commented Jun 21, 2023

dschuff commented Jun 21, 2023

kripken commented Jun 21, 2023

kripken commented Jun 21, 2023

kripken commented Jun 22, 2023

		@@ -1382,7 +1382,7 @@ var DYNCALLS = false;
		// i64 is used. If WASM_BIGINT is present, the default minimum supported browser
		// versions will be increased to the min version that supports BigInt.

		self.emcc_args += ['-lembind']
		self.node_args += shared.node_bigint_flags()

Enable WASM_BIGINT by default #19156

Are you sure you want to change the base?

Enable WASM_BIGINT by default #19156

Conversation

kripken commented Apr 10, 2023

kripken commented Apr 11, 2023

sbc100 commented Apr 11, 2023

sbc100 commented Apr 11, 2023

kripken commented Apr 11, 2023 • edited Loading

sbc100 commented Apr 11, 2023

sbc100 Apr 11, 2023

Choose a reason for hiding this comment

sbc100 Apr 11, 2023

Choose a reason for hiding this comment

sbc100 Apr 12, 2023

Choose a reason for hiding this comment

kripken Apr 12, 2023

Choose a reason for hiding this comment

kripken Apr 12, 2023

Choose a reason for hiding this comment

sbc100 commented Apr 12, 2023

kripken commented Apr 12, 2023

sbc100 commented Jun 21, 2023

dschuff commented Jun 21, 2023

kripken commented Jun 21, 2023

kripken commented Jun 21, 2023

kripken commented Jun 22, 2023

kripken commented Apr 11, 2023 •

edited

Loading