Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable _LARGEFILE64_SOURCE when _GNU_SOURCE is defined #20123

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Re-enable _LARGEFILE64_SOURCE when _GNU_SOURCE is defined #20123

merged 1 commit into from
Aug 30, 2023

Commits on Aug 30, 2023

  1. Re-enable _LARGEFILE64_SOURCE when _GNU_SOURCE is defined 

    When we updated to the latest version of musl it broke some codebases
that were using LFS functions (e.g. `stat64`) and assuming those
functions would be defined when `_GNU_SOURCE` is defined.

See bminor/musl@25e6fee

This change effectively reverts the above one by defining
_LARGEFILE64_SOURCE whenever _GNU_SOURCE is defined.

This is what glibc does:

https://github.com/lattera/glibc/blob/895ef79e04a953cac1493863bcae29ad85657ee1/include/features.h#L206
    @sbc100
    sbc100 committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    8045c65 View commit details
    Browse the repository at this point in the history