Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embind - Fix reading various bindings types from val on wasm64. #21225

Merged

Commits on Jan 31, 2024

  1. embind - Fix reading various bindings types from val on wasm64.

     - The function simpleReadValueFromPointer was always reading pointers as
    i32 numbers which was incorrect on wasm64.
    - Decoding of std::wstring was using a right shift to read pointers. Right
      shift was truncating numbers larger than i32 and causing misreads.
    - Added tests to execute readValueFromPointer on all the binding types
      to ensure these don't break on wasm64.
    brendandahl committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    7637d97 View commit details
    Browse the repository at this point in the history