-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC] Assert we do not use --low-memory-unused when STACK_FIRST #21291
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -360,6 +360,9 @@ def get_binaryen_passes(memfile): | |
# hardcoded value in the binaryen pass) | ||
if optimizing and settings.GLOBAL_BASE >= 1024: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps instead you want to add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, good idea, I see now that indeed we already parse this, so makes sense to read it from there. Done. |
||
passes += ['--low-memory-unused'] | ||
# we cannot do this if the stack is first, but we only put it first if not | ||
# optimizing | ||
assert not settings.STACK_FIRST | ||
if settings.AUTODEBUG: | ||
# adding '--flatten' here may make these even more effective | ||
passes += ['--instrument-locals'] | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
-v
to the command line is a cleaner why to do this I think (and generates less output)